eclipse-theia/theia

textEditor.commands.showReferences command fails after assigning keybinding

Open

#5,559 opened on Jun 21, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedkeybindingsmonaco

Description

Description

When you run the textEditor.commands.showReferences command after assigning it a keybinding it fails with:

TypeError: Cannot read property 'map' of undefined
    at Object.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command.ts:138:31)
    at MonacoCommandRegistry.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command-registry.ts:72:57)
    at Object.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command-registry.ts:61:47)
    at KeybindingRegistry.tryKeybindingExecution (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/keybinding.ts:570:44)
    at KeybindingRegistry.run (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/keybinding.ts:619:18)
    at HTMLDocument.<anonymous> (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/frontend-application.ts:164:72)

Reproduction Steps

Opening the keybinding shortcuts widget, assign keybinding, open a typescript file and put it over something you would expect to work with show references.

Expected: showReferences is brought up

Result: The error listed above

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Theia codebasebasic understanding of monaco editor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the error at packages/monaco/src/browser/monaco command.ts line 138 where 'Cannot read property 'map' of undefined' occurs. The issue is that when the command is triggered via a keybinding, the argument expected by showReferences is undefined. Compare how the command is called normally vs via keybinding and ensure the necessary argument is passed. Check the KeybindingRegistry execution path in packages/core/src/browser/keybinding.ts.