eclipse-theia/theia

Ctrl-P does not work when focus is on terminal

Open

#5,152 opened on May 15, 2019

View on GitHub
 (5 comments) (0 reactions) (1 assignee)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedterminalui/ux

Description

Description

When the focus is on the terminal Ctrl-P does not nothing instead of opening the "File chooser".

Other apps:

  • VsCode: Open "File chooser", regardless of context/focus
  • local terminal app: scroll up in command history

As a User I would expect the VsCode behavior.

Note: This is no problem for Mac users because there "File chooser" action is mapped to "Cmd-P".

Reproduction Steps

Negative:

  1. Click on terminal to give focus
  2. Hit Ctrl-P => nothing happens

Positive:

  1. Click on file navigator to give focus
  2. Hit Ctrl-P => File chooser opens

OS and Theia version:

Diagnostics: none

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptfamiliarity with Theia keybinding systembasic web development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine how Theia manages keybinding contexts, focusing on the terminal's focus state. Look at the keybinding configuration in files like keybinding.ts and the terminal widget's focus event handling. Determine why the Ctrl P binding is not triggered when the terminal is focused, possibly due to a missing or incorrect keybinding context. Review similar issues resolved in the repository for patterns.