eclipse-theia/theia

Eclipse Keybindings Extensions has no Effect

Open

#5,113 opened on May 10, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedkeybindingsvscode

Description

The Eclipse keymap extension for VS Code registers two bindings for "ctrl-shift-f". The declaration only differs in their "when" clause:

            {
                "mac": "cmd+shift+f",
                "win": "ctrl+shift+f",
                "linux": "ctrl+shift+f",
                "key": "ctrl+shift+f",
                "command": "editor.action.formatSelection",
                "when": "editorTextFocus && editorHasSelection"
            },
            {
                "mac": "cmd+shift+f",
                "win": "ctrl+shift+f",
                "linux": "ctrl+shift+f",
                "key": "ctrl+shift+f",
                "command": "editor.action.formatDocument",
                "when": "editorTextFocus && !editorHasSelection"
            },

I believe this is valid according to https://code.visualstudio.com/docs/getstarted/keybindings, but at startup I get an error (below) and initialization of the plugin seems to fail (Eclipse shortcuts are not present, like "ctrl-g".

root WARN Collided keybinding is ignored;  {"command":"editor.action.formatDocument","keybinding":"ctrl+shift+f"}  collided with  {"command":"editor.action.formatSelection","keybinding":"ctrl+shift+f"}
root WARN Could not register keybinding:
  {"command":"editor.action.formatDocument","keybinding":"ctrl+shift+f"}
Error: "ctrl+shift+f" is in collision with something else [scope:1]
root INFO [hosted-plugin: 29136] PLUGIN_HOST(29136): PluginManagerExtImpl/init()

root INFO [hosted-plugin: 29136] PLUGIN_HOST(29136): initializing(/home/thomas/chedev/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue involves two keybindings with the same key (ctrl+shift+f) but different 'when' clauses, which causes a collision error. To fix, examine the Eclipse keymap extension's package.json to adjust the keybindings or their when clauses. Also investigate Theia's keybinding registration logic in the plugin ext package to see if it should support such overlapping bindings. Relevant files include the plugin's package.json and the keybinding service in packages/plugin ext.
Eclipse Keybindings Extensions has no Effect · eclipse-theia/theia#5113 | Good First Issue