eclipse-theia/theia

URL path escapes '@' symbol, which breaks the url

Open

#4,927 opened on Apr 17, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
help wanted

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Description

I have theia running under JupterLab, the username in the url is an email address and contains an @, for example:

/users/rayh@example.com/theia

While I can load the page, the websocket url escapes the @ and therefore breaks the url and the websocket connection cannot be established.

In webpack:///./node_modules/vscode-uri/lib/esm/index.js - if I flip skipEncoding to true, the url now works, but i suspect this will not encode the request params. image

Here is the failing connection: image

Reproduction Steps

Simplest test would be to deploy theia under a url path that contains an '@'

OS and Theia version: Theia 0.5.0 running in Ubutnu 18.04.1 LTS

Contributor guide

Research direction
Locate the URL encoding logic in the codebase, specifically in vscode uri or similar URI handling code. Investigate why the '@' character is being encoded when it should not be in path segments.
Tech stack
typescriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65