eclipse-theia/theia

URL path escapes '@' symbol, which breaks the url

Open

#4,927 opened on Apr 17, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wanted

Description

Description

I have theia running under JupterLab, the username in the url is an email address and contains an @, for example:

/users/rayh@example.com/theia

While I can load the page, the websocket url escapes the @ and therefore breaks the url and the websocket connection cannot be established.

In webpack:///./node_modules/vscode-uri/lib/esm/index.js - if I flip skipEncoding to true, the url now works, but i suspect this will not encode the request params. image

Here is the failing connection: image

Reproduction Steps

Simplest test would be to deploy theia under a url path that contains an '@'

OS and Theia version: Theia 0.5.0 running in Ubutnu 18.04.1 LTS

Contributor guide

Tech stack
typescriptnodejs
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScriptunderstanding of URL encoding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the vscode uri library, specifically the file `lib/esm/index.js` where the `skipEncoding` flag is used. The issue suggests flipping it to `true` fixes the websocket URL, but may affect encoding of other request params. Investigate whether a localized fix can be applied to avoid global changes. Also look at Theia's websocket connection code to see how the URL is constructed and where the encoding occurs. Consider adding a test for URLs containing special characters like '@'.