eclipse-theia/theia

[editor] Group unsaved editors in one dialog when prompting user to save them

Open

#4,849 opened on Apr 10, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
editorhelp wantedui/ux

Description

In VS Code, when I close multiple dirty editors, the dirty editors are grouped in one dialog: Screen Shot 2019-04-10 at 09 56 10

Theia asks for each editor: screencast 2019-04-10 09-57-07

Group them. In theory, this can be configurable, but no need to overcomplicate it. Offer the user to save all or nothing. If she is unsure, she can press cancel and manage the dirty editors manually.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Theia's editor save mechanismUnderstanding of Theia's dialog system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how the editor close handler works, likely in 'packages/editor/src/browser/editor manager.ts'. Look for the 'saveAll' or 'closeAll' logic. Study the existing dialog API in '@theia/core/lib/browser/dialogs' to create a single confirmation dialog listing all dirty editors. The goal is to replace multiple consecutive prompts with one aggregated dialog offering save all, discard all, or cancel.