eclipse-theia/theia

[Feature] Pass event to CommandHandler

Open

#4,738 opened on Mar 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
enhancementhelp wantedtoolbar

Description

Description

I was looking into the new sidepanel toolbar and I wanted to register a toolbar item for one of my sidenav widgets that, on click, opens a context menu with more actions. This requires the click event's payload in order to extract the target which serves as an anchor point for the context menu. Before we had the sidepanel toolbar I created my own toolbar widget and was able to access the event object.

My workaround for now is to query the element using document.getElementById

const el = document.getElementById(MyCommands.SETTINGS.id);

and use that to call contextMenuRenderer.render.

OS and Theia version: OSX Mojave 10.14, Theia 0.5.0-next.21d54a76

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptTheia extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate how CommandHandler is currently defined and invoked. Look at theia/packages/core/src/browser/command.ts to understand the command execution flow. Determine where the event object should be passed (e.g., from toolbar click handlers). Modify the CommandHandler interface to accept an optional event parameter and update the execution path accordingly. Check existing command handlers for consistency.