eclipse-theia/theia

[mini-browser] Cannot set the focus to the mini-browser widget

Open

#4,368 opened on Feb 19, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedmini-browser

Description

With 2d090d38 from the master.

Steps to reproduce.

  • Create an index.html with <h1>FOOO</h1> content.
  • Select > Open With > Previw.
logger-protocol.ts:112 root WARN Widget was activated, but did not accept focus: mini-browser:file:///Users/akos.kitta/Desktop/minibrowser/learnnextjs-demo/index.html

Contributor guide

Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of Theia widget systemTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue reports that the mini browser widget does not accept focus when opened via 'Open With > Preview'. The log message indicates the widget was activated but focus was not set. To fix, examine the mini browser widget implementation in the Theia repository, likely in package 'mini browser'. Look at the focus handling logic, possibly in a widget class that extends from a base widget. Ensure that the widget's `onActivateRequest` method properly calls `this.node.focus()` or similar. Check if there are any recent changes that might have affected focus behavior. No comments or linked PRs exist as of now.