eclipse-theia/theia

`**` `files.exclude` filter should filter everything in the navigator

Open

#4,300 opened on Feb 11, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
bughelp wantednavigator

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

This is a follow-up issue of #4274. Most likely, nobody wants to filter all items from the navigator, so this is a minor defect.

{
    "files.exclude": {
        "**": true
    }
}

Current behavior: All files with a leading . (dot) are visible in the navigator.

Expected behavior: No files are visible in the navigator.

screencast 2019-02-11 16-51-07

Contributor guide

Research direction
Examine the implementation of files.exclude pattern matching in the navigator to understand why '**' does not exclude dotfiles. Look for the code that processes the exclude patterns and how it handles the '**' glob.
Tech stack
typescriptnodejs
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70