eclipse-theia/theia

`**` `files.exclude` filter should filter everything in the navigator

Open

#4,300 opened on Feb 11, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantednavigator

Description

This is a follow-up issue of #4274. Most likely, nobody wants to filter all items from the navigator, so this is a minor defect.

{
    "files.exclude": {
        "**": true
    }
}

Current behavior: All files with a leading . (dot) are visible in the navigator.

Expected behavior: No files are visible in the navigator.

screencast 2019-02-11 16-51-07

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate how the `files.exclude` pattern matching is implemented in Theia's file navigator, specifically the handling of the `**` pattern. The issue states that files with a leading dot are still visible when `**` is set as an exclude pattern. Look at the file tree component and the exclude filter logic to find where the glob matching might incorrectly skip hidden files. Expected fix: ensure that `**` matches all files, including dotfiles.