eclipse-theia/theia

[editor] dismiss context menu on scroll

Open

#2,660 opened on Aug 24, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugeditorhelp wantedmonaco

Description

I was expecting either system behavior (no scrolling while context menu is visible) or the same as in monaco playground:

2018-08-24 13 28 14

but currently the context menu just stays on top at the fixed position if you try scrolling:

2018-08-24 13 28 29

the UX issue is that you're moving away from the original selection, which is context of that menu.

Contributor guide

Tech stack
typescriptjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the context menu implementation in the Theia editor (likely in packages/editor or packages/monaco). Look for where the context menu is shown and how it handles scroll events. The expected behavior is to dismiss the menu on scroll (as in Monaco playground). Check existing event listeners on the editor's scrolling container and see if there is a listener that hides the context menu on scroll. If not, add one. Refer to similar implementations in Monaco or other editor components within Theia.