eclipse-theia/theia

[editor] dismiss context menu on scroll

Open

#2,660 opened on Aug 24, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
bugeditorhelp wantedmonaco

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

I was expecting either system behavior (no scrolling while context menu is visible) or the same as in monaco playground:

2018-08-24 13 28 14

but currently the context menu just stays on top at the fixed position if you try scrolling:

2018-08-24 13 28 29

the UX issue is that you're moving away from the original selection, which is context of that menu.

Contributor guide

Research direction
Find where the context menu is implemented and add a scroll event listener to dismiss it.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60