eclipse-theia/theia

Workspace service does not handle updates on network drives

Open

#12132 opened on Feb 1, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedworkspace

Description

Bug Description:

If I create a multiroot workspace on a network drive then Workspace service couldn't handle workspace root updates. https://github.com/eclipse-theia/theia/blob/b28c8b9d543e7df6c5d2bc524d40c50414df7e4d/packages/workspace/src/browser/workspace-service.ts#L104 "event.contains(this._workspace.resource)" Condition is always false because this._workspace.resource == "/u:/my-workspace" and event.changes[0].resource == "/userbackup/admin/my-workspace/roots.json" But u:/ and /userbackup/admin are the same drives. Nevertheless, "event.contains" check returns false

Steps to Reproduce:

  1. Create multiroot workspace on a network drive where
  2. Open ide on this workspace
  3. Edit the file containing workspace roots
  4. Workspace service couldn't handle file update

Additional Information

  • Operating System: Windows 10

Contributor guide

Tech stack
typescriptnodejs
Domain
backenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsTypeScriptFile system path handling on Windows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is in workspace service.ts at line 104 where event.contains checks URI equality but network drive paths differ (e.g., 'u:/' vs '/userbackup/admin'). Investigate how URIs are constructed on Windows and consider using fs.realpathSync or a path normalization utility. Check Theia's URI utilities for cross platform path handling.