eclipse-theia/theia

The extension Robot Framework Language Server creates a new terminal window after each launching

Open

#11,169 opened on May 17, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
debughelp wantedterminal

Description

Bug Description:

The extension Robot Framework Language Server creates a new terminal window after each launching

Steps to Reproduce:

  1. Build & run Theia
  2. Install the extension Robot Framework Language Server (version v0.34.0 is available for Theia, btw v0.47.2 is available for VScode)
  3. Clone and open demo-project https://github.com/robotframework/RobotDemo
  4. Open file data_driven.robot
  5. Each launching of a test suite or single test creates a new terminal window

Additional Information

  • Operating System: Ubuntu 20.04, MacOS 12.3.1 (Monterey)
  • Theia Version: 1.21, 1.25, master

P.S. VScode doesn't have a similar problem, but current version of the Robot Framework Language Server for it is v0.47.2

Contributor guide

Tech stack
typescript
Domain
backenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Theia's terminal APIUnderstanding of extension lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Robot Framework Language Server extension's test launch mechanism in Theia. Examine how Theia creates terminal windows for tasks (likely using the terminal service). Look into the extension's contribution points and see if there's a misconfiguration causing a new terminal per launch. Consider updating terminal reuse logic in Theia's task service. Reference files: terminal widget.ts, task terminal process.ts.