Escalate ProcessInfoNode construction failures
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- cpp
- Domain
- operating-systems
Research direction
Locate the Graph and ProcessInfoNode constructors and the existing error path for alive supervision construction failures. Trace how startup builds these components; done means a ProcessInfoNode construction failure is propagated so startup fails instead of logging the error and continuing.
Written by the indexing model from the issue text.
Description
What
After #522, if alive supervision construction fails in the process info node, we log an error and move on. This failure should instead be escalated and startup should fail.
Acceptance Criteria (DoD)
A failure in ProcessInfoNode's construction should cause a failed startup
How
Graph and ProcessInfoNode's constructors could be changed to Create() methods that can return a value to indicate failure
The above solution would not be suitable as it makes in-place construction of ProcessInfoNode difficult, necessitating a move, which would slow down construction of large graphs.
Alternatively, ProcessInfoNode's existing constructor could be changed so that it cannot fail. This would mean that the caller would have to construct the process's alive supervision, passing it to ProcessInfoNode only if it succeeds. On a failure, the Graph constructor would fail. Since only one Graph object is constructed, a single move operation should not have a significant performance impact, so a Create method may be suitable here.
- Dominant language
- C++
- Stars
- 6
- Forks
- 34
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 83
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-score/lifecycle
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
eclipse-score/lifecycle#407 ·
-
cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eclipse-score/lifecycle#375 ·
-
Feature Req Open
Difficulty 3/5 1-2 days Newbie friendliness 55/100
eclipse-score/lifecycle#664 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
eclipse-score/lifecycle#652 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
eclipse-score/lifecycle#649 · 1 comment ·
All issues in eclipse-score/lifecycle
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·