Group similar related config members

Open
#600 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
backend

Research direction

Start by reading the existing config accessors and PR #522, then inspect how Graph and ProcessGroupManager consume takeComponents, takeRunTargets, takeInitialRunTarget, and takeFallbackRunTarget. Done means those four accessors are replaced by one accessor returning all run-target organisation information, while takeAliveSupervision and takeWatchdog remain separate.

Written by the indexing model from the issue text.

Description

cleanup
What

Currently the config provides the following methods at the top level:

  • takeComponents
  • takeRunTargets
  • takeInitialRunTarget
  • takeFallbackRunTarget
  • takeAliveSupervision
  • takeWatchdog

The first 4 listed are all properties of run target organisation (responsibility of Graph and ProcessGroupManager, while 5 and 6 are unrelated. PR #522 introduces a wrapper around these members, GraphConfig, to allow PGM and Graph to take only the config relating to their roles without needing 3 extra parameters.

Acceptance Criteria (DoD)

The first 4 accessor methods (takeComponents, takeRunTargets, takeInitialRunTarget, takeFallbackRunTarget) should be replaced with a single one that returns all the information needed to organise run targets

How

No response

Dominant language
C++
Stars
6
Forks
34
Avg merge
1d 23h
Merged PRs (30d)
83

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-score/lifecycle

All issues in eclipse-score/lifecycle

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.