Make use of static create methods

Open
#488 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
backend

Research direction

Search the repository for init() and construct(), starting with the alive monitor and other construction paths mentioned in the issue. Identify each affected class and its existing error-handling tests; the work is done when those methods are removed or private and the agreed static Create() pattern covers construction failures.

Written by the indexing model from the issue text.

Description

cleanup
What

In alive monitor, but also elsewhere, there are init(), construct(), and other similar method names to handle situations where construction can fail, but we want to handle the error. A cleaner pattern could be to use a static Create() method that returns a newly created object or error on failure

Acceptance Criteria (DoD)
  • construct() and init() methods are removed or made private
How

No response

Dominant language
C++
Stars
6
Forks
34
Avg merge
2d 6h
Merged PRs (30d)
91

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-score/lifecycle

All issues in eclipse-score/lifecycle

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.