make_clang_tidy_aspect should skip source files from external Bzlmod repositories (similar to angle_includes_are_system for headers)

Open
#4 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Domain
build-system, tooling

Research direction

Start at the make_clang_tidy_aspect implementation and compare its external-file handling with angle_includes_are_system. Reproduce the issue using the external Bzlmod source example from the report; it is done when warnings from such source files are suppressed without per-target workarounds.

Written by the indexing model from the issue text.

Description

enhancement

When a target lists a source file from an external Bzlmod dep in srcs (e.g. srcs = ["@score_baselibs//score/mw/log:log_stream_test.cpp"]), the clang-tidy aspect processes it and flags issues in that external file — even though the downstream project has no control over it (can't add // NOLINT or #pragma).

make_clang_tidy_aspect already applies angle_includes_are_system = True to suppress warnings from external headers. An analogous mechanism for source files from external repos would eliminate the need for per-target no-clang-tidy workarounds in downstream projects.

Tracking workaround: eclipse-score/logging#77 (score/mw/log/detail/common/BUILD — log_stream_test).

Dominant language
Python
Stars
0
Forks
2
Avg merge
11h 37m
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.