Add regression test for sysroot flags on assembly actions

Open

#147 opened on Sep 15, 2026 0 comments 0 reactions 1 assignee View on GitHub

@nradakovic is already working on this.

Since Sep 15, 2026.

Assessment

This issue has not been assessed yet.

Description

Context

Issue #141 fixed missing --sysroot for assemble/preprocess-assemble actions (fix: sysroot_link_flags feature). The fix shipped without regression coverage because a naive test is unsound.

Why a naive test doesn't work

A .S fixture including a sysroot header (e.g. <features.h>) passes even without --sysroot: the host's /usr/include provides the same glibc (2.39) headers as the autosd10 sysroot, so header resolution alone cannot distinguish sysroot from host fallback — the exact failure mode of #141.

Proposed approach

Assert the resolved command line instead of build success:

A guardrail-style analysis test (pattern: tests/guardrails/legacy_feature_guard.bzl)
that resolves the active toolchain and verifies --sysroot=<sysroot> is
present in the flags for assemble and preprocess-assemble actions, and
that -Wl,--sysroot is NOT (linker-only flag).
Alternative: an aquery-based check on a .S target's CppCompile action.

Acceptance criteria

Test fails when assembly_actions is removed from the sysroot_link_flags feature.
Test fails if -Wl,--sysroot leaks into assembly actions.
Runs on Linux x86_64 and aarch64 configs; no target hardware needed.

Dominant language: Starlark
Stars: 2
Forks: 11
Avg merge: 1d 14h
Merged PRs (30d): 10

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.