eclipse-jdt/eclipse.jdt.core

Follow up on minimal target change to 1.8

Open

#2,761 opened on Jul 25, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Java (183 forks)auto 404
compilerhelp wanted

Repository metrics

Stars
 (233 stars)
PR merge metrics
 (PR metrics pending)

Description

Open TODO's from https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2551

Created issues:

Following questions wait for answering by others:

  • [Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
  • [Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
  • [Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
    • the test implies to test AST at JLS8
    • using source from project Converter, Converter15, however, selects the AST level from the project. @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?

Contributor guide

Research direction
Examine the linked PR #2551 and related issues to understand the context of the minimal target change to 1.8. Address the open questions from Stephan regarding test configuration and test placement. Consider implementing the remaining unchecked issue #2757.
Tech stack
java
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70