Add setter-functions for object attributes that consist of `NamespaceSet`s

Open

#65 opened on Apr 18, 2023 2 comments 0 reactions 0 assignees View on GitHub

@zrgt is already working on this.

Since Aug 28, 2026.

#619 by @zrgt — open

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 25/100

Issue type: Feature
Clarity: Mostly clear
Activity status: Stale
Tech stack: python
Domain: backend

Research direction

Start with the AssetAdministrationShell constructor in basyx/aas/model/aas.py around the ConceptDictionary parameter, then inspect NamespaceSet and ObjectStore handling. Review linked pull request #619 before changing anything. Done means assignments to NamespaceSet-backed attributes no longer leave invalid iterable values that later fail during ObjectStore iteration.

Written by the indexing model from the issue text.

Description

enhancement sdk

When instantiating an AssetAdministrationShell-object, we hand over ConceptDictionarys in any kind of Iterable (See here)

def __init__(self,
                 ...
                 concept_dictionary: Iterable[concept.ConceptDictionary] = (),
                 ...):

However, internally, we create a NamespaceSet containing these ConceptDictionarys in order to be able to resolve them later:

self.concept_dictionary: base.NamespaceSet[concept.ConceptDictionary] = \
            base.NamespaceSet(self, concept_dictionary)

Now, if a user were to only look at the initialization parameters, and wanted to add a ConceptDictionary later, after initalization, they could theoretically assume, they could set it like this:

my_aas.concept_dictionary = [my_concept_dictionary]

This would have terrible results when iterating over ObjectStores containing these objects, since suddenly, we'd get the (not very helpful) error:

AttributeError: 'list' object has no attribute 'update_nss_from'

This obviously points nowhere in the right direction.

I have the suspicion, that this is not the only time, where such a problem may arise. How can we restrrict the user from making such a mistake in the first place? Should we write getter and setter functions for these kinds of attributes? On the other hand, maybe this is something to be checked by the ObjectStore, when adding an item to it?

Dominant language: Python
Stars: 102
Forks: 52
Avg merge: 20d 17h
Merged PRs (30d): 1

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

validate-structure inspecte challenge/work/.terraform et rend faux les labs qui ont un provider en cache Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

stephrobert/dsoxlab#238 · Opened Sep 24, 2026
Uniform probability densities use the upper bound as an interval width Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

nasa/fmdtools#40 · Opened Sep 24, 2026
_common_folder() treats a single file as the common folder; single-file archives can't be installed (4.2.8) / crash (master) Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

sublimehq/package_control#1780 · Opened Sep 24, 2026
Set 'Sample' input in 'autorun.py' to utilize 'Sample' Tab in eLog Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

pcdshub/mfx#309 · 2 comments · Opened Sep 24, 2026
niri config file addition does not respect existing optional include Open

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

nwg-piotr/nwg-displays#145 · Opened Sep 24, 2026

More Python issues