server: 'DictDescriptorStore' is missing 'commit()', causing 500 on registry writes

Open Beginner friendly
#626 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
api, backend

Research direction

Start in server/app/model/provider.py and compare DictDescriptorStore with the SDK's DictObjectStore commit behavior. Exercise the registry's POST and PUT /shell-descriptors paths in the default configuration. Done means both writes complete without a 500 from NotImplementedError; also review the AbstractObjectStore commit declaration noted in the issue.

Written by the indexing model from the issue text.

Description

bug server

DictDescriptorStore (server/app/model/provider.py) has no commit() method, so it uses the SDK's default one, which just raises NotImplementedError(). The registry calls commit() on every add/update, so POST/PUT to /shell-descriptors returns 500 in the default config.

Proposed fix: add a no-op commit() to DictDescriptorStore, like the SDK's DictObjectStore already has.

Root cause is that the commit() method in the abstract base class AbstractObjectStore is not flagged as an abstract method.
We should consider adding the correct decorator.

Dominant language
Python
Stars
102
Forks
52
Avg merge
20d 17h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-basyx/basyx-python-sdk

All issues in eclipse-basyx/basyx-python-sdk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.