ebay-filter-chip: missing disabled state styling (light + dark theme)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- css
- Domain
- frontend
Research direction
Start with the shared @ebay/skin CSS used by the filter-chip component and compare its light and dark states with the linked Figma design. Use the React Storybook EbayFilterChip entry, toggle disabled=true, and confirm that the disabled state is visibly different in both themes for the affected wrappers.
Written by the indexing model from the issue text.
Description
I verified there's no existing issue for this bug.
- There are no existing issues
Current behavior
The filter-chip component doesn't include any visual difference when disabled (for dark or light theme). The root cause is in the shared @ebay/skin CSS, which has no disabled-state styles defined for filter-chip — so this affects every framework wrapper (Marko and React), not just one. Reproducible in the React Storybook.
Expected behavior
In Figma it appears there should be styles for when the component is set to disabled.
Package and version
Root cause is in @ebay/skin (no disabled-state styles defined for filter-chip), so it affects @ebay/ebayui-core, @ebay/ui-core-react (originally reported against 9.7.0), @evo-web/marko, and @evo-web/react as well.
Device/OS/Browser info
No response
Steps to reproduce
1. Go to EbayFilterChip storybook https://opensource.ebay.com/evo-web/ebayui-core-react/main/?path=/docs/form-input-ebay-filter-chip
2. toggle disabled=true
3. See no visual change
Relevant code block
No response
Additional context
Confirmed that the current Evo Web version matches Playbook, so this was likely just a missed state rather than a Playbook/Evo Web divergence. A similar pattern was seen recently with ebay-filter-chip's expressive variant border-radius, filed and fixed as #761.
- Dominant language
- TypeScript
- Stars
- 51
- Forks
- 52
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 44
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eBay/evo-web
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
blocked: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
blocked: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
package: ebayui-core-react status: ready for code
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100