dylang/npm-check

Npm-check 5.1 is too zealous while looking for missing modules

Open

#123 opened on Apr 4, 2016

View on GitHub
 (12 comments) (7 reactions) (0 assignees)JavaScript (6,438 stars) (278 forks)batch import
help wantedissue is in a dependencywho else wants this?

Description

Hello! First of all, thanks for your work, I love this helper as I love to keep my projects with depencies up to date!

Anyway since updating to 5.1 I noticed an annoying behaviour: npm-check is starting to look for modules everywhere, even in .eslintrc or karma.conf.js!

The worst part is that I use webpack resolve's modulesDirectories options to load my modules with absolute paths from the root of my project, so I have a lot of this calls:

import Header from 'components/header' or import * as api from 'utils/api'

Before 5.1 they were ignored, while now they are all caught making the report unreadable:

actions                             �  MISSING!  Not installed.
                                        �  PKG ERR!  Not in the package.json. Found in: \src\scripts\actio
ns\animations.js, \src\scripts\actions\blocks.js, \src\scripts\actions\currentConversation.js, \src\script
s\actions\mail.js, \src\scripts\components\Main.jsx...

and so on.

I tried also with the -s flag but it skips a lot of modules so it's not viable either.

Contributor guide

Tech stack
javascriptnodejs
Domain
clitoolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The bug is a regression in version 5.1 where npm check scans non module files like .eslintrc and karma.conf.js. Look at the file scanning logic, likely in the lib directory, and compare git changes between 5.0 and 5.1 to find the commit that introduced the broader search. Add filtering to exclude common configuration files and ensure the fix aligns with the intended behavior of checking only import/require statements.