dylanaraps/neofetch

Refresh rate not measured correctly "FHD"Hz instead of 144

Open

#1,604 opened on Nov 11, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Shell (23,680 stars) (1,792 forks)batch import
Help WantedMac OS

Description

Description

My 144Hz monitor is listed as a FHDHz monitor

Does this issue still occur in the master branch?

Yes

Neofetch version

Both 7.1.0 and the latest version from the master branch (commit 0c1a799) are affect

Screenshot

98753688-d045ef00-23bc-11eb-89fd-0f3f6a7971e1

Config file

https://gist.github.com/BitGrub/0638d52e6996b4ab39ae1df544107ac8

Verbose log

https://gist.github.com/BitGrub/9f09c6fd6e22c5f2e50baf0b032987e6

Contributor guide

Tech stack
shell
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic bash scriptingstring parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the code that retrieves and displays the monitor refresh rate, likely in the neofetch script. The issue shows 'FHDHz' instead of a numeric value, suggesting a parsing error. Look at the relevant section handling xrandr or similar output, and ensure the refresh rate is extracted correctly without concatenating with resolution strings.