dylanaraps/neofetch

Cannot determine Navi 10 cards

Open

#1,552 opened on Sep 9, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Shell (23,680 stars) (1,792 forks)batch import
EnhancementHelp Wanted

Description

Description

I am using a Sapphire 5700XT but my output makes it seem that neofetch isn't able to determine what version it is.

  • Does this issue still occur in the master branch? (Required if issue)

Yes

Neofetch version

current master, commit bfbefc7f6bacf3016a973e8c874b2346fae539e1. v 7.1.0.

Screenshot

Config file

vanilla

Verbose log

[!] Config: Sourced user config.    (/home/adnan338/.config/neofetch/config.co)
[!] Image: Imagemagick not found, falling back to ascii mode.
[!] Info: Couldn't detect Terminal Font.
[!] Neofetch command: /usr/bin/neofetch -v
[!] Neofetch version: 7.1.0

https://pastebin.com/XeB6uhEB

Expected output:

$ screenfetch 
           /:-------------:\          adnan338@localhost.localdomain
        :-------------------::        OS: Fedora 
      :-----------/shhOHbmp---:\      Kernel: x86_64 Linux 5.8.4-200.fc32.x86_64
    /-----------omMMMNNNMMD  ---:     Uptime: 5h 59m
   :-----------sMMMMNMNMP.    ---:    Packages: 1786
  :-----------:MMMdP-------    ---\   Shell: bash 5.0.17
 ,------------:MMMd--------    ---:   Resolution: 3840x2160
 :------------:MMMd-------    .---:   DE: GNOME 3.36.4
 :----    oNMMMMMMMMMNho     .----:   WM: Mutter
 :--     .+shhhMMMmhhy++   .------/   WM Theme: 
 :-    -------:MMMd--------------:    GTK Theme: Adwaita-dark [GTK2/3]
 :-   --------/MMMd-------------;     Icon Theme: Adwaita
 :-    ------/hMMMy------------:      Font: Carlito 11
 :-- :dMNdhhdNMMNo------------;       Disk: 96G / 3.6T (3%)
 :---:sdNMMMMNds:------------:        CPU: AMD Ryzen 9 3900XT 12-Core @ 24x 3.8GHz
 :------:://:-------------::          GPU: AMD Radeon RX 5700 XT (NAVI10, DRM 3.38.0, 5.8.4-200.fc32.x86_64, LLVM 10.0.1)
 :---------------------://            RAM: 4837MiB / 16017MiB

Contributor guide

Tech stack
shell
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with bash scriptingunderstanding of GPU detection in neofetch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is that neofetch fails to identify the AMD Radeon RX 5700 XT (Navi 10). The GPU detection logic is likely in the neofetch script, possibly in a function that parses lspci or similar. Look at the relevant section of the script (e.g., get gpu) and add the missing vendor/device IDs for Navi 10 cards. The solution is to add a mapping in the GPU detection code so that the card is correctly recognized as 'AMD Radeon RX 5700 XT'.