dylanaraps/neofetch

Add Windows Terminal font support

Open

#1,513 opened on Jul 25, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Shell (23,680 stars) (1,792 forks)batch import
EnhancementHelp Wanted

Description

Currently output of Terminal is just /dev/pts/* on WSL2 and /dev/tty* on WSL1. Besides, no term font is shown. When running on Windows Terminal, variables $WT_PROFILE_ID and $WT_SESSION is available.

--- neofetch	2020-07-25 01:31:17.290000000 +0800
+++ file	2020-07-25 10:36:19.370000000 +0800
@@ -3136,6 +3136,9 @@
     [[ "$TERM" == "tw52" || "$TERM" == "tw100" ]] && term="TosWin2"
     [[ "$SSH_CONNECTION" ]] && term="$SSH_TTY"
 
+    # Windows Terminal temporarily support
+    [[ "$WT_SESSION" ]] && term="Windows Terminal"
+
     # Check $PPID for terminal emulator.
     while [[ -z "$term" ]]; do
         parent="$(get_ppid "$parent")"

As for term fonts, default configuration file is /mnt/<disk>/Users/<Username in Windows>/AppData/Local/Packages/Microsoft.WindowsTerminal_8wekyb3d8bbwe/LocalState/settings.json.

However, I don't know how to deal with json.

Contributor guide

Tech stack
shell
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
bash scriptingJSON parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, examine the current terminal detection logic in neofetch around the provided patch location (line 3136+). The issue already includes a patch for identifying Windows Terminal via $WT SESSION. For font support, investigate Windows Terminal's settings.json path: /mnt/<disk>/Users/<Username>/AppData/Local/Packages/Microsoft.WindowsTerminal 8wekyb3d8bbwe/LocalState/settings.json. The JSON contains a 'profiles' array; extract the font face from the default profile. Ensure to handle cases where the file is missing or malformed. Since this issue is from 2020, verify if the file path or JSON structure has changed in current Windows Terminal versions.