dwyl/phoenix-ecto-append-only-log-example

Use `.city` instead of `[:city]` in history test

Open

#20 opened on Dec 29, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Elixir (5 forks)auto 404
help wanted

Repository metrics

Stars
 (82 stars)
PR merge metrics
 (PR metrics pending)

Description

In the get history of an item test, I got the following:

     test/append/address_test.exs:56
     ** (UndefinedFunctionError) function Append.Address.fetch/2 is undefined (Append.Address does not implement the Access behaviour)
     code: assert h1[:city] == "Asgard"
     stacktrace:
       (append) Append.Address.fetch(%Append.Address{__meta__: #Ecto.Schema.Metadata<:loaded, "addresses">, address_line_1: "The Hall", address_line_2: "Valhalla", city: "Asgard", entry_id: "b0cccc58-f3ea-4b9d-9b57-9b79c2bbf69a", id: 100, inserted_at: ~N[2018-12-29 20:29:29.782939], name: "Thor", postcode: "AS1 3DG", tel: "0800123123", updated_at: ~N[2018-12-29 20:29:29.782939]}, :city)
       (elixir) lib/access.ex:318: Access.get/3
       test/append/address_test.exs:70: (test)

In my own code I fixed this by changing the assert statements to check h1.city instead of h1[:city] (and likewise for h2).

Contributor guide

Research direction
Change the test assertions to use dot notation (`h1.city`) instead of the Access syntax (`h1[:city]`) for the struct fields.
Tech stack
elixir
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitElixir basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95