dwyl/learn-redux

'addTodo' and 'setVisibilityFilter' actions are unused in index.html example

Open

#50 opened on Sep 11, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)HTML (446 stars) (42 forks)batch import
help wanted

Description

I was just annotating a print out of the code to remind myself of some of the concepts learned in the video tutorials, and found the following issues:

  • addTodo action is unused: should replace the dispatch action in the AddTodo component
  • setVisibilityFilter action is unused: should be used by the dispatch action in the mapDispatchToLinkProps method

Contributor guide

Tech stack
javascriptreacthtml
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Redux conceptsfamiliarity with React components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue identifies that 'addTodo' and 'setVisibilityFilter' actions are declared but not used in the index.html example. The fix involves replacing the direct dispatch calls in the AddTodo component and mapDispatchToLinkProps with these action creators. No linked PRs or comments exist, so the solution requires editing the index.html file to correctly import and use the actions.