dwyl/learn-redux

'addTodo' and 'setVisibilityFilter' actions are unused in index.html example

Open

#50 opened on Sep 11, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)HTML (42 forks)batch import
help wanted

Repository metrics

Stars
 (446 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I was just annotating a print out of the code to remind myself of some of the concepts learned in the video tutorials, and found the following issues:

  • addTodo action is unused: should replace the dispatch action in the AddTodo component
  • setVisibilityFilter action is unused: should be used by the dispatch action in the mapDispatchToLinkProps method

Contributor guide

Research direction
Inspect the index.html file in the repository. Find where addTodo and setVisibilityFilter actions are defined but not used. Replace the dispatch calls in AddTodo component and mapDispatchToLinkProps with the appropriate action creators.
Tech stack
javascriptreact
Domain
frontend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85