dwyl/learn-json-web-tokens

Issue with default expiry time

Open

#43 opened on Aug 3, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (4,175 stars) (267 forks)batch import
bughelp wanted

Description

The intention is to expire in 7 days, but the code doesn't provide a number thats 7 days ahead of now...far from it! https://github.com/dwyl/learn-json-web-tokens/blob/master/example/lib/helpers.js#L39

$ node
> var x = Math.floor(new Date().getTime()/1000) + 7*24*60*60
undefined
> new Date(x)
Sat Jan 17 1970 15:46:41 GMT+0000 (BST)
>

I used this instead:

Date.now() + (1000 * 60 * 60 * 24 * 7)

Contributor guide

Tech stack
javascriptnodejs
Domain
backendsecurity
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of Unix timestamps
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The bug is in the helper.js file at line 39, where the expiry time is calculated incorrectly using Math.floor(new Date().getTime()/1000) + 7*24*60*60, which gives seconds since epoch but then passed to new Date() which expects milliseconds. The fix is to use Date.now() + 1000*60*60*24*7 to add 7 days in milliseconds. No further investigation needed; the issue provides the correct solution.