dwyl/learn-json-web-tokens

Issue with default expiry time

Open

#43 opened on Aug 3, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (267 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,175 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The intention is to expire in 7 days, but the code doesn't provide a number thats 7 days ahead of now...far from it! https://github.com/dwyl/learn-json-web-tokens/blob/master/example/lib/helpers.js#L39

$ node
> var x = Math.floor(new Date().getTime()/1000) + 7*24*60*60
undefined
> new Date(x)
Sat Jan 17 1970 15:46:41 GMT+0000 (BST)
>

I used this instead:

Date.now() + (1000 * 60 * 60 * 24 * 7)

Contributor guide

Research direction
Review the helpers.js file and replace the incorrect timestamp calculation with Date.now() + 7*24*60*60*1000.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90