dwyl/english-words

Chore: Review all the open Pull Requests and Attempt to merge them ๐Ÿง‘โ€๐Ÿ’ป

Open

#155 opened on Nov 10, 2022

View on GitHub
ย (2 comments)ย (2 reactions)ย (0 assignees)Pythonย (9,687 stars)ย (1,760 forks)batch import
T4hchorediscussenhancementhelp wantedpriority-3technical

Description

At present there are 20 open Pull Requests: https://github.com/dwyl/english-words/pulls

image

This is both a great and a really bad sign. ๐ŸŽ‰ ๐Ÿ˜•

On the positive side it's awesome that people want to contribute to the project [not just take the words and give nothing back...] and continually renews my faith in Open Source! ๐Ÿ˜

But the down-side of having so many PRs open is that the efforts of several people are wasted ... ๐Ÿ˜ž ewe need to do a much better job of communicating how to contribute.

https://github.com/dwyl/english-words/pull/130 is an example of one that clearly took some effort and will add value to people! ๐Ÿ‘Œ So we need to make every effort to ensure that the effort was not wasted! โณ

Note: this is priority-3 ("nice to have") because while we definitely want to maintain and improve this repo, we have extremely limited time. And since we are not currently using it in our App ... we cannot justify the time allocation/investment right now. That's why I've "ignored" the open PRs. ๐Ÿ™„ Only features that relate to the App are given higher priority. It's possible that we could use English Words in the App e.g. for auto-completion/suggestion. In which case the priority of updating/maintaining this repo/project would be raised.

Todo

  • Review the PR: ๐Ÿ‘€

    • Assign it to yourself and add the label: in-review ๐Ÿ‘จโ€๐Ÿซ
    • View the code/words updates and leave comments ๐Ÿ’ฌ
    • If you feel it's immediately mergeable, approve it and assign it to me. ๐Ÿ™
    • If it's not mergable, please leave a comment for the author (including an apology for the delay and link to this issue) ๐Ÿ”—
  • Criteria that qualifies for merging:

  • Instantly reject PRs that update Zip files and explain that Zip files files are commonly used for viruses so we cannot afford to trust anyone with updating them. "It's not you, it's me/us" we "Trust No One" https://en.wikipedia.org/wiki/Trust_no_one_(Internet_security)

@LuchoTurtle you mentioned this repo to me verbally in our catch up yesterday. If you want to make a stab at reviewing the open PRs in a Pomodoro Break, go for it! Please just leave a comment on this issue first and link to the PR you're picking off.

Contributor guide