dvdciri/daggraph

Add constructor injected dependencies to the graph

Open

#53 opened on Aug 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,147 stars) (61 forks)batch import
featurehelp wanted

Description

Daggraph need to be able to recognise constructor injected dependencies and add them to the graph.

There are some open questions here:

  • Where should we put the class which is constructor injecting some dependencies?
  • Where should we put the injected dependencies?

This is the regex for koltin: /(?:class)\s(\w*).*?(?:@Inject).*?(?:constructor)\((.*?)\)\s?\{/gs This is the regex for java: /(?:@Inject).*?\s(\w*?)\((.*?)\)\s?{/gs

Contributor guide

Tech stack
kotlinjava
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
regex basicsJava/Kotlin class syntaxDagger dependency injection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue targets adding constructor injected dependencies to the Daggraph graph. The provided regex patterns for Kotlin and Java need to be integrated into the parser logic. The main files to examine are likely in the parsing module (e.g., `src/parser.js` or similar). Currently, the issue has open questions about node placement for the injecting class and injected dependencies. A maintainer should clarify these design choices before implementation. The work involves modifying the regex based detection and graph construction, possibly adding new node types.
Add constructor injected dependencies to the graph · dvdciri/daggraph#53 | Good First Issue