dvdciri/daggraph

Add constructor injected dependencies to the graph

Open

#53 opened on Aug 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (61 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (1,147 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Daggraph need to be able to recognise constructor injected dependencies and add them to the graph.

There are some open questions here:

  • Where should we put the class which is constructor injecting some dependencies?
  • Where should we put the injected dependencies?

This is the regex for koltin: /(?:class)\s(\w*).*?(?:@Inject).*?(?:constructor)\((.*?)\)\s?\{/gs This is the regex for java: /(?:@Inject).*?\s(\w*?)\((.*?)\)\s?{/gs

Contributor guide

Research direction
Examine the existing graph model and parsing logic in Daggraph. Understand how classes and dependencies are currently extracted. Then, extend the regex patterns to capture constructor injection in both Kotlin and Java as provided. Decide on graph placement (e.g., node for injected class, edges for injected dependencies). Look at similar existing features for guidance.
Tech stack
javascriptkotlinjava
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Dependency injectionRegexDaggraph codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65