dvcrn/markright

Unsaved changes reported without editing anything

Open

#30 opened on Nov 12, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Clojure (904 stars) (58 forks)batch import
bughelp wanted

Description

Repro (on Windows 10)

  • Start MarkRight
  • Open Markdown document
  • Don't change anything
  • Application window title does NOT show a "changed" indicator (*)
  • Close application window
  • Dialog box appears: "There are unsaved changes. Are you sure you want to continue? Your changes will be lost"

If I save the document immediately after opening it, I don't get the message. In general, the handling of the "changed" state seems to work correctly after the first save.

Contributor guide

Tech stack
javascripthtmlcsselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Electron app lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the dirty state tracking logic in the Markright codebase, likely in the main process or renderer. Look for where the 'changed' indicator is toggled and the unsaved changes dialog is triggered, possibly in the window close handler. Focus on the initial state after opening a document without modifications. Check any event listeners for file content changes.