dustinblackman/Championify

Special Items/Upgrades

Open

#167 opened on Apr 4, 2016

View on GitHub
 (7 comments) (0 reactions) (1 assignee)HTML (893 stars) (163 forks)batch import
enhancementhelp wanted

Description

Some champions have special things they buy in the shop. For Gangplank, he has his ult upgrades. Not sure champion.gg tracks which upgrade is taken first/second/third but at any rate, an option to upgrade when running the top/mid page would be very nice. (This alleviates having to goto recommended or all items). Not sure about Rengar or Khazix since I don't own either of those champions. Kalista is fine since she starts with the item IIRC.

Contributor guide

Tech stack
javascripthtmlcss
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of JavaScriptUnderstanding of League of Legends item system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the item set generation logic, especially how special upgrades are handled for champions like Gangplank. The issue mentions requiring an option to upgrade the ult, so look at the current UI for item selection and how data is fetched from Champion.gg. The assignee may have started work; check the repository for any related branches or comments. Files likely involved include the main view and data parsing modules.