duo-labs/parliament

Check the services mentioned for aws:CalledVia

Open

#84 opened on Feb 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (954 stars) (88 forks)batch import
enhancementgood first issue

Description

According to https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-keys.html#condition-keys-calledvia there are only four services that can currently be used with aws:CalledVia. I should check those are being used, especially to ensure no misspellings happen.

Contributor guide

Tech stack
python
Domain
security
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of AWS IAM condition keys
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, check the AWS documentation at https://docs.aws.amazon.com/IAM/latest/UserGuide/reference policies condition keys.html#condition keys calledvia to confirm the four services that support aws:CalledVia. Then, search the Parliament codebase (likely in the IAM policy validation logic) for any hardcoded list of services or condition key handling to see if any misspellings or incorrect services are used. Update the code to correctly validate or handle only the four allowed services. There is no existing PR or maintainer clarification needed.