duo-labs/parliament

Add aws:PrincipalAccount

Open

#164 opened on Dec 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (954 stars) (88 forks)batch import
enhancementgood first issue

Description

The global conditionaws:PrincipalAccount needs to be added. Possibly others.

https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-keys.html

This needs to be added here: https://github.com/duo-labs/parliament/blob/66c6588a8559def5fd644cbc66196ff2009aada9/parliament/statement.py#L151

Contributor guide

Tech stack
python
Domain
securitycloud
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AWS IAM basicsPython environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the file parliament/statement.py at line 151 (linked in the issue) and add the string 'aws:PrincipalAccount' to the list of global condition keys. The list is likely a tuple or set. Also check the AWS documentation for other missing condition keys (e.g., 'aws:PrincipalOrgID') and add them if appropriate. Run the existing tests to ensure no regressions.