dtolnay/syn

Use Literal::subspan to produce better spans from LitStr::parse

Open

#621 opened on Apr 15, 2019

View on GitHub
 (1 comment) (4 reactions) (0 assignees)Rust (372 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (3,326 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

LitStr::parse currently puts the entire input string's span on every output token. It would be better to try producing smaller spans using Literal::subspan.

Contributor guide

Research direction
Investigate how LitStr::parse currently assigns spans and determine how to use Literal::subspan to produce more precise spans.
Tech stack
rust
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65