dtolnay/mashup

Reject strings containing characters that are not allowed in ident

Open

#13 opened on Oct 5, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (5 forks)github user discovery
good first issue

Repository metrics

Stars
 (95 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The following should fail to compile.

mashup! {
    m["x"] = a "+" b;
}

Contributor guide

Research direction
Investigate the parsing logic in mashup's macro implementation to detect and reject identifiers containing invalid characters such as '+'. Check the identifier validation function and add a compile time error.
Tech stack
rust
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustprocedural macros
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50