dtolnay/cxx

Support rust::Vec and std::vector of SharedPtr to Opaque types

Open

#741 opened on Mar 17, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Rust (4,472 stars) (253 forks)batch import
help wanted

Description

I understand, why we can't hold opaque types in both vectors, but why we can't hold SharedPtrs to this types?

Those functions are currently unavailable.

#[cxx::bridge]
mod ffi {
  unsafe extern "C++" {
    fn opaqueVector() -> &'static CxxVector<SharedPtr<CxxString>>;
    fn opacueVec() -> Vec<SharedPtr<CxxString>>;
  }
}

Contributor guide

Tech stack
rustcpp
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustC++CXX librarySharedPtr concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the current implementation of CxxVector and Vec in the CXX codebase, particularly how opaque types are handled. Look at the existing support for SharedPtr and determine why vectors of SharedPtr to opaque types are not allowed. Consider modifications to the code generation in the CXX bridge to enable this pattern. Files to examine: include/cxx.h, src/cxx.cc, and the Rust side lib.rs in the cxx crate.