dtolnay/cxx

Raw identifiers in methods in extern "C++" block leads to wrong C++ code generation

Open

#1,324 opened on Mar 11, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (253 forks)batch import
help wanted

Repository metrics

Stars
 (4,472 stars)
PR merge metrics
 (Avg merge 8m) (3 merged PRs in 30d)

Description

For example

pub fn highlight(r#type: i32);

leads to

void ffi$cxxbridge1$highlight(::std::int32_t r#type) noexcept { ... }

I wish it could be unraw-ed if being a valid C++ identifier. Currently workaround with type_.

Contributor guide

Research direction
Find the code that generates C++ function parameter names and strip the `r#` prefix when the identifier is a valid C++ identifier.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75