dtolnay/cargo-expand

Show progress bar

Open

#62 opened on Apr 20, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (73 forks)github user discovery
help wanted

Repository metrics

Stars
 (3,090 stars)
PR merge metrics
 (Avg merge 4m) (1 merged PR in 30d)

Description

Currently the Cargo subprocess spawned by cargo-expand does not display Cargo's usual progress bar. I believe this is because we pipe the child's stderr to perform filtering here:

https://github.com/dtolnay/cargo-expand/blob/3ae4ca126a4bd557ef7f7954911d65db56525b37/src/main.rs#L358

and that means Cargo does not get a winsize from this ioctl:

https://github.com/rust-lang/cargo/blob/6be12653dcefb46ee7b605f063ee75b5e6cba513/src/cargo/core/shell.rs#L377

I tried a naive fix in #61 but it didn't work, the second ioctl fails with:

Inappropriate ioctl for device (os error 25)

Will need to figure out what's the correct way to provide a winsize to the child process.

Contributor guide

Research direction
Investigate how to provide a winsize to the child process, possibly by setting the terminal size via environment variables or using a pseudo terminal (pty) to forward the winsize.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustCargo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40