dthree/vorpal

Hitting CTRL+C while in Inquirer prompt breaks everything

Open

#42 opened on Nov 1, 2015

View on GitHub
 (16 comments) (0 reactions) (0 assignees)JavaScript (5,609 stars) (313 forks)batch import
bughelp wanted

Description

The output looks like this:

(^C again to quit)
function (str) {
  if (str === undefined) {
    return this._delimiter;
  }
  this._delimiter = String(str).trim() + ' ';
  if (this.isLocal()) {
    this.parent.ui.refresh();
  } else {
    this.parent._send('vantage-delimiter-downstream', 'downstream', {value: str, sessionId: this.id});
  }
  return this;
}
_

You can still type but nothing happens. Only way to recover is hitting CTRL+C again.

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptNode.js CLI developmentUnderstanding of process signals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate how Vorpal sets up the Inquirer prompt and handles SIGINT signals. Look at the Inquirer library's behavior on Ctrl+C and how it interacts with Vorpal's internal state. The code snippet in the issue shows a function that might be from Vorpal's delimiter logic; check the refresh method and the send method. Consider implementing a proper cleanup or reset of the prompt state on Ctrl+C.