dthree/vorpal

[for discussion] move default localStorage location under $HOME

Open

#122 opened on Mar 1, 2016

View on GitHub
 (11 comments) (3 reactions) (0 assignees)JavaScript (5,609 stars) (313 forks)batch import
bughelp wanted

Description

i ran into a problem when trying out your cash project. With my nodejs/npm setup, global installs require sudo: sudo npm i -g cash

however, because of that, cash doesn't have permissions to write to its own localstorage directory:

$ cash
fs.js:794
  return binding.mkdir(pathModule._makeLong(path),
                 ^

Error: EACCES: permission denied, mkdir '/Users/tenaciousmv/npm/lib/node_modules/cash/node_modules/vorpal/dist/.local_storage'

obviously i don't want to run cash with sudo :)

isn't it more typical to put this kind of storage in ~/.vorpal or ~/.cash or somewhere else under $HOME?

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsvorpal frameworkbasic file system knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue suggests moving the default localStorage directory from inside the npm global install path to under the user's home directory (e.g., ~/.vorpal). To fix, locate the code in vorpal that sets the localStorage path (likely in the local storage.js or similar file in the dist folder). Change the default to use os.homedir() or process.env.HOME, and ensure the directory is created with appropriate permissions. Test the change by installing cash globally with sudo and running cash to verify no permission errors.