dthree/vantage

Persistent history

Open

#30 opened on Aug 10, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (3,450 stars) (134 forks)batch import
enhancementhelp wanted

Description

Command history is handy, but it doesn't live beyond a session. It would be awesome if vantage had persistent history. As of now, this can only be achieved by loading entries into vagrant.session._hist.

History could be kept server-side on a per-user basis, or client-side on a per-host basis.

For a server-side implementation, instead of bundling this functionality with vantage itself, a public history API could be exposed for extensions to manage and provide history, with session history as the default implementation.

A client-side implementation could provide a vantage command-line flag to pick a history file, defaulting to something like ~/.vantage/history/<host> (for system-wide, per-host history) or ./vantage/history (for directory-based history).

Contributor guide

Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Node.js basicsVantage library understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue proposes two approaches: server side (via an API for extensions) and client side (via a history file flag). Explore existing terminal CLIs (e.g., , fish) for persistent history patterns. Look into Vantage's session history implementation in `lib/session.js` and the ` hist` property. Consider implementing a simple file based client side history with a configurable path, defaulting to `~/.vantage/history`. Evaluate trade offs between server side and client side in terms of complexity and user needs. Check comments for any prior discussion on preferred direction.