dthree/cash

standalone cash-cat doesn't copy stdin

Open

#6 opened on Feb 23, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (7,768 stars) (253 forks)batch import
help wantednon-compliant behavior

Description

Cool project!

When using cash-cat as a standalone command, it doesn't appear to support copying stdin when no arguments are present. For example:

    npm install cash-cat
    $ echo hi | ./node_modules/.bin/cat
    $

Am I doing something wrong here?

Thanks, Kevin

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Node.js knowledgeUnderstanding of stdin streams
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that the standalone cash cat command does not copy stdin when invoked without arguments. To fix, examine the cat command implementation, likely in src/cat.js or similar. Look for how the command reads from stdin when no file arguments are given. Check other cash commands that handle stdin for reference. Ensure that stdin is piped to stdout when no files are specified. The fix likely involves adding a check for no arguments and then reading from process.stdin.