dschep/ntfy

ntfy shell integration ignore doesn't match subcommand.

Open

#191 opened on Feb 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (4,716 stars) (219 forks)batch import
enhancementhelp wanted

Description

Many useful tools have subcommands which need different notify policy. For example, git log and git clone should be handled differently. Currently a command is only judged by its basename (source). Is it possible that ntfy support subcommand match in the future?

Contributor guide

Tech stack
pythonshell
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
bash scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the current implementation in ntfy/shell integration/auto ntfy done.sh line 21 where basename matching occurs. Consider how to extend the pattern to match subcommands, e.g., by splitting the command string. Check if there are any existing suggestions in the issue comments (1 comment). The solution should maintain backward compatibility.