Patch-package should aggregate all errors for failing patches.
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- nodejs, typescript
- Domain
- developer-experience, tooling
Research direction
Start with src/patch/read.ts at the linked line and compare its failure handling with the changes introduced on the ^8.1.0-canary.1 branch. Trace the other patch-failure paths to identify which ones still exit immediately. Done means failing patches are aggregated and can be targeted by package, with a consistent package-specific error indication.
Written by the indexing model from the issue text.
Description
While testing ^8.1.0-canary.1 branch, which introduces changes to how the The patches for <package_name> have changed. errors are aggregated for failing patches, I've noticed there are other ways the patch can fail. For example, the ... could not be parsed. error from read.ts which exits the process altogether.
It would be beneficial to have this error path as well as other ones also receive the treatment from ^8.1.0-canary.1 branch so that the packages for failing patches could be targeted individually instead of having to reinstall node_modules, thus saving time and improving DX. Another idea would be to introduce a part of the error message would be the same for all such errors, e.g. there was a problem with <package_name>, which would help out with getting the correct name for failing patch/package for all the errors.
- Dominant language
- TypeScript
- Stars
- 11.2k
- Forks
- 325
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ds300/patch-package
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
ds300/patch-package#617 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ds300/patch-package#615 · 3 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ds300/patch-package#216 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
ds300/patch-package#611 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ds300/patch-package#610 · 2 comments · 1 reaction ·
All issues in ds300/patch-package
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
danielmiessler/LifeOS#2218 ·