Allow to disable `error-on-fail` even on CI

Open
#558 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
node.js, typescript
Domain
cli, tooling

Research direction

Start in src/index.ts at lines 110-114 and inspect how the isCI value affects the --error-on-fail option. Reproduce the option behavior in a CI-like environment, then verify that an explicit override works there while the existing non-CI behavior remains unchanged.

Written by the indexing model from the issue text.

Description

It is not possible to override --error-on-fail option on the CI:

https://github.com/ds300/patch-package/blob/bd2e9a49d884516199079add143c1649541e8efe/src/index.ts#L110-L114

If isCI is true then value of --error-on-fail is ignored.

Dominant language
TypeScript
Stars
11.2k
Forks
325
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ds300/patch-package

All issues in ds300/patch-package

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.