"trino" entry points conflicts with `sqlalchemy-trino`

Open
#427 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python, sqlalchemy
Domain
databases

Research direction

Start with the SQLAlchemy entry-point definitions in setup.py around line 72 and inspect how the "trino" name is registered. Confirm the naming used by sqlalchemy-trino and check the project’s existing tests or packaging checks. Done means PyHive no longer registers the conflicting name while its dialect remains discoverable under the agreed replacement.

Written by the indexing model from the issue text.

Description

PyHive defines a "trino" entry point for a SQLAlchemy dialect:

https://github.com/dropbox/PyHive/blob/master/setup.py#L72

If you have both PyHive and sqlalchemy-trino installed both will register the same dialect, and each request will randomly use one of the libraries.

Can we rename the PyHive entry point to trino+pyhive, or something else different?

Dominant language
Python
Stars
1.7k
Forks
545
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dropbox/PyHive

All issues in dropbox/PyHive

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.