drogonframework/drogon

Passing binary arrays directly to a resp->setBody()

Open

#2,139 opened on Aug 24, 2024

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C++ (1,014 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (10,462 stars)
PR merge metrics
 (Avg merge 5d 16h) (3 merged PRs in 30d)

Description

It's disheartening to dance on eggshells when trying to pass a large binary array to drogon's setBody method. Nothing works. No shared_ptr, no string_view, nothing. The only way to pass a binary array right now seems to be using the list constructor of std::string by calling std::string fullResponse(char* myData, size_t myDataSize); and then calling std::move to hand it over to the setBody method, which involves a wholly unnecessary copy operation. Yes, compared to the compression, serialization, its not really THAT relevant. Nonetheless, what I would like is a method overload which accepts a char* and a size_t. The same goes for the send() method of the async stream.

Contributor guide

Research direction
Add a new overload of setBody that accepts a char* and size t to avoid unnecessary copy. Also apply similar change to send method of async stream.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75