drizzle-team/drizzle-orm

[BUG]: `not` type doesn't work with `and` and `or`

Open

#1818 opened on Jan 21, 2024

View on GitHub
 (11 comments) (2 reactions) (0 assignees)TypeScript (16,414 stars) (357 forks)batch import
good first issueimprovementpriorityqb/crud

Description

What version of drizzle-orm are you using?

0.29.3

What version of drizzle-kit are you using?

0.20.9

Describe the Bug

await db.query.users.findMany({
  where: not(and(ilike(users.name, '%asdf%')))
})

This gives a type error. If you cast the and expression as SQLWrapper it works properly.

Expected behavior

not should accept SQL

Environment & setup

No response

Contributor guide

Tech stack
typescriptdrizzlenodejssql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptdrizzle orm basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the type definitions for `not` and `and` functions in the drizzle orm source code. Check the `SQLWrapper` interface and how `not` expects its argument. The issue suggests `not` should accept `SQL<unknown>`, so examine the return type of `and` and ensure compatibility. Look for relevant type tests in the repository to understand the expected behavior.