drizzle-team/drizzle-orm

[BUG]: `not` type doesn't work with `and` and `or`

Open

#1,818 opened on Jan 21, 2024

View on GitHub
 (11 comments) (2 reactions) (0 assignees)TypeScript (357 forks)batch import
good first issueimprovementpriorityqb/crud

Repository metrics

Stars
 (16,414 stars)
PR merge metrics
 (Avg merge 10d 10h) (9 merged PRs in 30d)

Description

What version of drizzle-orm are you using?

0.29.3

What version of drizzle-kit are you using?

0.20.9

Describe the Bug

await db.query.users.findMany({
  where: not(and(ilike(users.name, '%asdf%')))
})

This gives a type error. If you cast the and expression as SQLWrapper it works properly.

Expected behavior

not should accept SQL

Environment & setup

No response

Contributor guide

Research direction
Inspect the type definitions of `not`, `and`, and `or` to understand why `not` does not accept the result type of `and`. Look for a missing overload or incorrect type signature in the `not` function.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70