drivendataorg/cloudpathlib

Tests: `tmpdir` is deprecated and we should use `tmp_path` instead

Open

#370 opened on Oct 9, 2023

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (87 forks)auto 404
good first issuetests

Repository metrics

Stars
 (624 stars)
PR merge metrics
 (PR metrics pending)

Description

We use tmpdir throughout the tests, but it is deprecated: https://docs.pytest.org/en/stable/how-to/tmp_path.html#the-tmpdir-and-tmpdir-factory-fixtures

We should remove replace tmpdir fixture with tmp_path throughout the test suite.

Originally posted by @jayqi in https://github.com/drivendataorg/cloudpathlib/pull/361#discussion_r1304854288

Contributor guide

Research direction
Replace all occurrences of the `tmpdir` fixture with `tmp path` in test files. The `tmp path` fixture returns a `pathlib.Path` object instead of a string based `py.path.local`. Adjust any code that uses the path as a string or calls methods specific to `py.path.local`. Refer to the pytest documentation for migration details.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90