drewnoakes/metadata-extractor

Index bugs in OlympusRawDevelopment2MakernoteDescriptor

Open

#448 opened on Nov 30, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (2,411 stars) (470 forks)batch import
bugformat-camera-rawgood-first-issuehelp wanted

Description

These two calls getIndexedDescription() need to start at 1 instead of 0:

https://github.com/drewnoakes/metadata-extractor/blob/ef906fb58057cb3355577c2e7c2d86aa5a4472b6/Source/com/drew/metadata/exif/makernotes/OlympusRawDevelopment2MakernoteDescriptor.java#L155

https://github.com/drewnoakes/metadata-extractor/blob/ef906fb58057cb3355577c2e7c2d86aa5a4472b6/Source/com/drew/metadata/exif/makernotes/OlympusRawDevelopment2MakernoteDescriptor.java#L162

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
Clone the repository from https://github.com/drewnoakes/metadata extractor. Navigate to Source/com/drew/metadata/exif/makernotes/OlympusRawDevelopment2MakernoteDescriptor.java. At lines 155 and 162, change the index argument from 0 to 1 in the calls to getIndexedDescription(). Verify the fix by running existing tests. Submit a pull request referencing this issue.